cloud connectors role chaining #2960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moukoublen
force-pushed
the
cloud_connectors_chaining
branch
from
34d5f72 to
e52824d
Compare
moukoublen
force-pushed
the
cloud_connectors_chaining
branch
from
540de53 to
54ed5af
Compare
moukoublen
force-pushed
the
cloud_connectors_chaining
branch
from
54ed5af to
a3154bf
Compare
kubasobon
approved these changes
Feb 11, 2025
olegsu
reviewed
Feb 11, 2025
olegsu
reviewed
Feb 11, 2025
|
|
||
| const defaultDuration = 5 * time.Minute | ||
|
|
||
| // Chain Part 1 - Elastic Super Role Local |
There was a problem hiding this comment.
Super role is misleading term, indicate that the role permissions are elevated when it only should be allowed to assume the global role
There was a problem hiding this comment.
I believe this is something to discuss in RFC level, wdyt?
olegsu
reviewed
Feb 11, 2025
| ) | ||
| localSuperRoleCredentialsCache := aws.NewCredentialsCache(localSuperRoleProvider) | ||
|
|
||
| // Chain Part 2 - Elastic Super Role Global |
There was a problem hiding this comment.
Super role is misleading term, indicate that the role permissions are elevated when we need only audit (SecurityAudit built-in AWS)
There was a problem hiding this comment.
The global super role has not the audit policy, it has no policy part from the "assume anything". Feel free to refer RFC regarding the terminology.
olegsu
reviewed
Feb 11, 2025
| ) | ||
| globalSuperRoleCredentialsCache := aws.NewCredentialsCache(globalSuperRoleProvider) | ||
|
|
||
| // Chain Part 3 - Elastic Super Role Local |
There was a problem hiding this comment.
Suggested change
| // Chain Part 3 - Elastic Super Role Local | |
| // Chain Part 3 - Elastic Remote SecurityAudit |
olegsu
reviewed
Feb 11, 2025
moukoublen
force-pushed
the
cloud_connectors_chaining
branch
3 times, most recently
from
5c25106 to
3aaf8c5
Compare
moukoublen
force-pushed
the
cloud_connectors_chaining
branch
from
40235b0 to
bb35e87
Compare
moukoublen
force-pushed
the
cloud_connectors_chaining
branch
from
bb35e87 to
eea5b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Screenshot/Data
Related Issues
Fixes: #2556
Checklist
Introducing a new rule?